sunchao commented on code in PR #5213: URL: https://github.com/apache/datafusion-comet/pull/5213#discussion_r3837577341
########## spark/src/test/scala/org/apache/comet/rules/EliminateRedundantTransitionsSuite.scala: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet.rules + +import org.apache.spark.sql.CometTestBase +import org.apache.spark.sql.comet.{CometColumnarToRowExec, CometNativeColumnarToRowExec, CometPlan} +import org.apache.spark.sql.execution.{ColumnarToRowExec, SparkPlan, UnionExec} + +import org.apache.comet.CometConf + +class EliminateRedundantTransitionsSuite extends CometTestBase { Review Comment: [P2] Register the new suite in both CI workflow matrices Could you add `org.apache.comet.rules.EliminateRedundantTransitionsSuite` to the suite lists in `pr_build_linux.yml` and `pr_build_macos.yml`? `dev/ci/check-suites.py` requires every non-exempt suite in both workflows. Running it against this exact head exits 255 with `Suite not found in workflow .github/workflows/pr_build_linux.yml: org.apache.comet.rules.EliminateRedundantTransitionsSuite`. The [live Preflight job](https://github.com/apache/datafusion-comet/actions/runs/30751822315/job/91507084214) fails for the same reason, which leaves the main Linux/macOS builds and Spark SQL jobs skipped, so neither the new regression test nor the main build matrix runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
