kosiew commented on code in PR #24591:
URL: https://github.com/apache/datafusion/pull/24591#discussion_r3844994302
##########
datafusion/physical-plan/src/topk/mod.rs:
##########
@@ -2950,6 +3073,260 @@ mod tests {
Ok((schema, state))
Review Comment:
Nice regression coverage here. One additional test that could be useful is a
small `PartitionedTopKExec` or window execution test with a bounded memory
pool. The reported user symptom is an execution-time `Resources exhausted`
failure, while these tests mainly validate the internal `size()` accounting. A
RANK case with many partitions that completes under a limit the old whole-batch
retention would have exceeded would also verify the reservation path end to
end. This is non-blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
