alamb commented on PR #24585: URL: https://github.com/apache/datafusion/pull/24585#issuecomment-5401767669
Maybe we can invest in some "mid level" tests -- aka make the testing the poll order easier For example, we could have some sort of insta / snapshot test that set up some streams and then polled them and output a trace of what stream got polled and in what order With such a testing framework, I think we could more easily reason about / understand the impacts of PRs like this My personal concern is also that this might accindentally regress something else (or maybe be regressed itself in the future) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
