mkleen commented on PR #23490:
URL: https://github.com/apache/datafusion/pull/23490#issuecomment-5405996487
So here is my suggestion:
- Create a FileSinkMetrics with the following structure:
```rust
pub struct FileSinkMetrics {
metrics: ExecutionPlanMetricsSet,
rows_written: Count,
bytes_written: Count,
time: Time,
}
```
- Init all fields in the the ctor and add accessors returning references
such as &Count etc to these fields
- Wire the `FileSinkMetrics` to the Sinks such as ParquetSink, CsvSink etc.
to use `FileSinkMetrics` for all of them
- Consume the counters etc. from there in the various sinks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
