mkleen commented on code in PR #23490:
URL: https://github.com/apache/datafusion/pull/23490#discussion_r3850050979


##########
datafusion/datasource/src/write/mod.rs:
##########
@@ -229,4 +288,68 @@ impl ObjectWriterBuilder {
         file_compression_type
             .convert_async_writer_with_level(buf_writer, compression_level)
     }
+
+    /// Build a compressed object writer and return a shared counter containing
+    /// the number of compressed bytes written to the object store writer.
+    pub(crate) fn build_with_byte_counter(

Review Comment:
   let's add a dedicated `with_byte_counter` function to the 
`ObjectWriterBuilder` and have only one `build` function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to