zhuqi-lucas commented on PR #24426: URL: https://github.com/apache/datafusion/pull/24426#issuecomment-5406601538
> > the filter column must be fully decoded to evaluate the threshold regardless; and for a high-cardinality key like SearchPhrase, RG pruning drops nothing — so the selection/mask construction is paid for zero payback. > > Thanks @zhuqi-lucas - I think I had claude try this - it is what is listed as > > > and a refinement ([106653a](https://github.com/apache/datafusion/commit/106653a393b8815e09c09db239afa966f0f627b3)) that gates only static conjuncts when a dynamic (TopK/aggregate) filter is present > > And it didn't seem to work (though perhaps it wasn't implemented correctly) Thank you @alamb for the info , i can try to benchmark it locally first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
