alamb commented on code in PR #24510: URL: https://github.com/apache/datafusion/pull/24510#discussion_r3852278747
########## docs/source/contributor-guide/index.md: ########## @@ -194,6 +201,12 @@ DataFusion has the following policy for AI-assisted PRs: - The PR author should **understand the core ideas** behind the implementation **end-to-end**, and be able to justify the design and code during review. - **Calls out unknowns and assumptions**. It's okay to not fully understand some bits of AI generated code. You should comment on these cases and point them out to reviewers so that they can use their knowledge of the codebase to clear up any concerns. For example, you might comment "calling this function here seems to work but I'm not familiar with how it works internally, I wonder if there's a race condition if it is called concurrently". +If we see multiple PRs being created in a short amount of time, especially from +a first time contributor, and we suspect AI involvement, we are at liberty to Review Comment: Maybe we can also try and direct contributors to more useful endeavors like reviewing others submissions -- perhaps I am being naive here, but I think that would also discourage lots of AI spam ########## docs/source/contributor-guide/index.md: ########## @@ -58,6 +58,13 @@ been able to finish it yet, you should feel free to work on it as well. In general it is both polite and will help avoid unnecessary duplication of work if you leave a note on an issue when you start working on it. +If there is already a recent/active PR for an issue you plan to work on, please Review Comment: maybe we can also suggest they help with the existing PR (e.g. help review it, work with the other contributor to get the PR to follow the guidelines / go through the review process) ########## AGENTS.md: ########## @@ -4,11 +4,19 @@ - [Quick Start Setup](docs/source/contributor-guide/development_environment.md#quick-start) - [Testing Quick Start](docs/source/contributor-guide/testing.md#testing-quick-start) +- [Open Contribution and Assigning tickets](docs/source/contributor-guide/index.md#open-contribution-and-assigning-tickets) - [Before Submitting a PR](docs/source/contributor-guide/index.md#before-submitting-a-pr) - [Reviewing Pull Requests](docs/source/contributor-guide/pr_review.md) - [Contributor Guide](docs/source/contributor-guide/index.md) - [Architecture Guide](docs/source/contributor-guide/architecture.md) +## Before starting work + +Before you start work on an issue, you MUST follow the instructions in +[Open Contribution and Assigning tickets](docs/source/contributor-guide/index.md#open-contribution-and-assigning-tickets). You must ensure duplicate work is not being created. Review Comment: We could perhaps soften this language "Please ensure duplicate work is not being created..." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
