gene-bordegaray commented on code in PR #24670:
URL: https://github.com/apache/datafusion/pull/24670#discussion_r3854285103
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -1041,6 +1042,7 @@ fn is_projection_removable(projection: &ProjectionExec)
-> bool {
};
col.name() == proj_expr.alias && col.index() == idx
}) && exprs.len() == projection.input().schema().fields().len()
+ && projection.schema() == projection.input().schema()
Review Comment:
We need to check full schema because even if the schema metadata is equal
things like the field metadata might not be thus we nee to check this as well.
I don't see anything in the schema which would be overestricting this. I may
be missing something though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
