gabotechs commented on code in PR #24670:
URL: https://github.com/apache/datafusion/pull/24670#discussion_r3854376229
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -1041,6 +1042,7 @@ fn is_projection_removable(projection: &ProjectionExec)
-> bool {
};
col.name() == proj_expr.alias && col.index() == idx
}) && exprs.len() == projection.input().schema().fields().len()
+ && projection.schema() == projection.input().schema()
Review Comment:
Pretty much the order of columns. I bet that's why the current checks are
like they are right now.
I think it's fine though, if this becomes too restrictive it will start
popping up in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
