NGA-TRAN commented on code in PR #24501:
URL: https://github.com/apache/datafusion/pull/24501#discussion_r3856155764
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -577,13 +582,15 @@ impl Partitioning {
allow_subset,
);
if satisfaction == PartitioningSatisfaction::NotSatisfied
- && allow_subset
&& range_monotonic_fn_satisfies_keys(
range,
required_exprs,
eq_properties,
)
{
+ // A monotonic transform of the range key (for example
+ // `date_bin(timestamp)`) is not Hash-subset logic, so
+ // this is independent of `allow_subset`.
Review Comment:
These are super clear. Thanks @jayshrivastava. Fixed in commit 394abcfd1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
