mkleen commented on code in PR #24646:
URL: https://github.com/apache/datafusion/pull/24646#discussion_r3854556597
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -840,6 +840,7 @@ impl AggregateUDFImpl for ApproxDistinct {
| DataType::Map(_, _)
| DataType::Struct(_)
| DataType::Union(_, _)
+ | DataType::Dictionary(_, _)
Review Comment:
Good point. Floats will unsupported see
https://github.com/apache/datafusion/pull/23084, So we should exclude them in
all container types.
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -840,6 +840,7 @@ impl AggregateUDFImpl for ApproxDistinct {
| DataType::Map(_, _)
| DataType::Struct(_)
| DataType::Union(_, _)
+ | DataType::Dictionary(_, _)
Review Comment:
Good point. Floats will be unsupported see
https://github.com/apache/datafusion/pull/23084, So we should exclude them in
all container types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
