Jefffrey commented on code in PR #24646:
URL: https://github.com/apache/datafusion/pull/24646#discussion_r3860100261
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -840,6 +840,7 @@ impl AggregateUDFImpl for ApproxDistinct {
| DataType::Map(_, _)
| DataType::Struct(_)
| DataType::Union(_, _)
+ | DataType::Dictionary(_, _)
Review Comment:
i still feel we can support floats here if we already support it in regular
distinct count 🤔
also for reference seems duckdb supports:
```sql
memory D select approx_count_distinct(a) from values (1.5::double), (1.5),
('nan'::double), (null), (0) t(a);
┌──────────────────────────┐
│ approx_count_distinct(a) │
│ int64 │
├──────────────────────────┤
│ 3 │
└──────────────────────────┘
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
