saadtajwar commented on PR #24681: URL: https://github.com/apache/datafusion/pull/24681#issuecomment-5418413905
NOTE: I know that this diff looks HUGE - important note that the **vast** majority of the diff in this PR is from the new organization of NLJ. The only new additions are in the SAM NLJ stream variant - the `exec.rs` is almost exactly copied & pasted besides choosing the SAM NLJ stream based on join type, the `materializing_stream` is almost the exact same besides using helpers that were moved out to `shared.rs`, etc. I definitely don't feel great asking someone to review this huge diff 😓 so if we think this is too big and needs to be organized into more, smaller PRs then I'm definitely happy to do so - if we think this is fine though, then once we get this in the PR2 for the regular join stream will hopefully be much much smaller :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
