Rachelint commented on PR #11943: URL: https://github.com/apache/datafusion/pull/11943#issuecomment-2294828572
I have finished some common accumulator's blocked version, here is the quick benchmark, the improvement seems obvious. ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ sketch-blocked-aggr-state-management ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.76ms │ 0.72ms │ +1.06x faster │ │ QQuery 1 │ 69.53ms │ 72.05ms │ no change │ │ QQuery 2 │ 166.96ms │ 168.59ms │ no change │ │ QQuery 3 │ 190.69ms │ 189.39ms │ no change │ │ QQuery 4 │ 1636.65ms │ 1649.38ms │ no change │ │ QQuery 5 │ 1626.03ms │ 1622.13ms │ no change │ │ QQuery 6 │ 68.64ms │ 69.72ms │ no change │ │ QQuery 7 │ 72.83ms │ 73.50ms │ no change │ │ QQuery 8 │ 2372.56ms │ 2458.88ms │ no change │ │ QQuery 9 │ 1981.86ms │ 2086.80ms │ 1.05x slower │ │ QQuery 10 │ 581.70ms │ 584.44ms │ no change │ │ QQuery 11 │ 650.20ms │ 659.55ms │ no change │ │ QQuery 12 │ 1783.70ms │ 1806.20ms │ no change │ │ QQuery 13 │ 3457.32ms │ 3470.38ms │ no change │ │ QQuery 14 │ 2610.41ms │ 2322.11ms │ +1.12x faster │ │ QQuery 15 │ 1860.80ms │ 1856.29ms │ no change │ │ QQuery 16 │ 5089.55ms │ 4468.02ms │ +1.14x faster │ │ QQuery 17 │ 4967.25ms │ 4239.42ms │ +1.17x faster │ │ QQuery 18 │ 10439.13ms │ 8627.08ms │ +1.21x faster │ │ QQuery 19 │ 153.57ms │ 154.77ms │ no change │ │ QQuery 20 │ 3381.41ms │ 3364.43ms │ no change │ │ QQuery 21 │ 3969.70ms │ 3964.51ms │ no change │ │ QQuery 22 │ 9207.24ms │ 9225.76ms │ no change │ │ QQuery 23 │ 23743.29ms │ 23666.93ms │ no change │ │ QQuery 24 │ 1173.06ms │ 1175.95ms │ no change │ │ QQuery 25 │ 1055.92ms │ 1045.69ms │ no change │ │ QQuery 26 │ 1367.16ms │ 1370.04ms │ no change │ │ QQuery 27 │ 4861.47ms │ 4904.54ms │ no change │ │ QQuery 28 │ 23586.33ms │ 23591.38ms │ no change │ │ QQuery 29 │ 942.54ms │ 940.82ms │ no change │ │ QQuery 30 │ 2105.76ms │ 2019.71ms │ no change │ │ QQuery 31 │ 2359.53ms │ 2140.82ms │ +1.10x faster │ │ QQuery 32 │ 8458.73ms │ 7073.03ms │ +1.20x faster │ │ QQuery 33 │ 9613.62ms │ 9638.96ms │ no change │ │ QQuery 34 │ 9653.83ms │ 9697.52ms │ no change │ │ QQuery 35 │ 3133.50ms │ 2874.52ms │ +1.09x faster │ │ QQuery 36 │ 265.57ms │ 265.14ms │ no change │ │ QQuery 37 │ 163.01ms │ 166.45ms │ no change │ │ QQuery 38 │ 164.37ms │ 163.61ms │ no change │ │ QQuery 39 │ 862.26ms │ 712.51ms │ +1.21x faster │ │ QQuery 40 │ 64.54ms │ 66.72ms │ no change │ │ QQuery 41 │ 61.29ms │ 59.67ms │ no change │ │ QQuery 42 │ 72.71ms │ 72.39ms │ no change │ └──────────────┴────────────┴──────────────────────────────────────┴───────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
