Rachelint commented on code in PR #11943:
URL: https://github.com/apache/datafusion/pull/11943#discussion_r1721975698
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -903,9 +992,14 @@ impl GroupedHashAggregateStream {
&& matches!(self.mode, AggregateMode::Partial)
&& self.update_memory_reservation().is_err()
{
- let n = self.group_values.len() / self.batch_size *
self.batch_size;
- let batch = self.emit(EmitTo::First(n), false)?;
- self.exec_state = ExecutionState::ProducingOutput(batch);
+ if !self.enable_blocked_group_states {
Review Comment:
I have removed codes added for trying to support this optimization spilling.
We should fix the exist problems in spilling first, and consider a efficient
way about supporting.
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -62,6 +63,7 @@ pub(crate) enum ExecutionState {
/// When producing output, the remaining rows to output are stored
/// here and are sliced off as needed in batch_size chunks
ProducingOutput(RecordBatch),
+ ProducingBlocks(Option<usize>),
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
