alamb commented on code in PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#discussion_r1720760725
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -195,6 +214,10 @@ impl ColumnarValue {
kernels::cast::cast_with_options(array, cast_type,
&cast_options)?,
)),
ColumnarValue::Scalar(scalar) => {
+ if scalar.data_type().logically_eq(cast_type) {
Review Comment:
> Datum is another concept other than ColumnarValue. It could be Array or
Scalar
`Datum` is the arrow-rs concept equivalent of `ColumnarValue::Scalar`
(though its implementation is different). Also, it is not yet widely supported
in arrow-rs kernels (it is mostly now supported in the core comparison
/equality kernels)
`ColumnarValue` and `ScalarValue` both significantly pre-date the
introduction of `Datum` to arrow-rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
