notfilippo commented on PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#issuecomment-2297514514
I've pushed a fairly big experiment. I've tried to change ColumnarValue to
```rust
#[derive(Clone, Debug)]
pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
Scalar(ScalarValue),
Scalar(Scalar),
}
#[derive(Clone, Debug)]
pub struct Scalar {
value: ScalarValue,
data_type: DataType,
}
```
which follows the approache that was discussed with @jayzhan211 in the
comments above. I've opted for this hybrid solution to retain most of the
flexibility of the original ColumnarValue and I'm mostly satisfied with how it
turned out. Curious to hear your thoughts @jayzhan211 and @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
