github-actions[bot] commented on PR #24714: URL: https://github.com/apache/datafusion/pull/24714#issuecomment-5434488679
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.0.0 (current) Built [ 29.997s] (current) Parsing datafusion-expr v55.0.0 (current) Parsed [ 0.075s] (current) Building datafusion-expr v55.0.0 (baseline) Built [ 29.752s] (baseline) Parsing datafusion-expr v55.0.0 (baseline) Parsed [ 0.074s] (baseline) Checking datafusion-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.217s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 62.591s] datafusion-expr Building datafusion-expr-common v55.0.0 (current) Built [ 20.199s] (current) Parsing datafusion-expr-common v55.0.0 (current) Parsed [ 0.018s] (current) Building datafusion-expr-common v55.0.0 (baseline) Built [ 20.418s] (baseline) Parsing datafusion-expr-common v55.0.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-expr-common v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.204s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 41.618s] datafusion-expr-common Building datafusion-functions-aggregate v55.0.0 (current) Built [ 31.791s] (current) Parsing datafusion-functions-aggregate v55.0.0 (current) Parsed [ 0.044s] (current) Building datafusion-functions-aggregate v55.0.0 (baseline) Built [ 32.228s] (baseline) Parsing datafusion-functions-aggregate v55.0.0 (baseline) Parsed [ 0.045s] (baseline) Checking datafusion-functions-aggregate v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.189s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 65.556s] datafusion-functions-aggregate Building datafusion-functions-aggregate-common v55.0.0 (current) Built [ 21.633s] (current) Parsing datafusion-functions-aggregate-common v55.0.0 (current) Parsed [ 0.020s] (current) Building datafusion-functions-aggregate-common v55.0.0 (baseline) Built [ 21.868s] (baseline) Parsing datafusion-functions-aggregate-common v55.0.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-functions-aggregate-common v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.138s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 44.546s] datafusion-functions-aggregate-common Building datafusion-physical-expr-common v55.0.0 (current) Built [ 24.828s] (current) Parsing datafusion-physical-expr-common v55.0.0 (current) Parsed [ 0.020s] (current) Building datafusion-physical-expr-common v55.0.0 (baseline) Built [ 25.141s] (baseline) Parsing datafusion-physical-expr-common v55.0.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-physical-expr-common v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.207s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 51.110s] datafusion-physical-expr-common Building datafusion-physical-plan v55.0.0 (current) Built [ 38.762s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.148s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 38.539s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.151s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.631s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_physical_plan::aggregates::group_values::multi_group_by::GroupColumn::values_preserving in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:114 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 79.543s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
