github-actions[bot] commented on PR #24670: URL: https://github.com/apache/datafusion/pull/24670#issuecomment-5438238594
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.0.0 (current) Built [ 29.380s] (current) Parsing datafusion-expr v55.0.0 (current) Parsed [ 0.078s] (current) Building datafusion-expr v55.0.0 (baseline) Built [ 29.259s] (baseline) Parsing datafusion-expr v55.0.0 (baseline) Parsed [ 0.075s] (baseline) Checking datafusion-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.226s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 61.357s] datafusion-expr Building datafusion-functions v55.0.0 (current) Built [ 31.745s] (current) Parsing datafusion-functions v55.0.0 (current) Parsed [ 0.083s] (current) Building datafusion-functions v55.0.0 (baseline) Built [ 31.265s] (baseline) Parsing datafusion-functions v55.0.0 (baseline) Parsed [ 0.086s] (baseline) Checking datafusion-functions v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.380s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 64.903s] datafusion-functions Building datafusion-physical-expr v55.0.0 (current) Built [ 29.447s] (current) Parsing datafusion-physical-expr v55.0.0 (current) Parsed [ 0.048s] (current) Building datafusion-physical-expr v55.0.0 (baseline) Built [ 29.398s] (baseline) Parsing datafusion-physical-expr v55.0.0 (baseline) Parsed [ 0.049s] (baseline) Checking datafusion-physical-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.336s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 60.099s] datafusion-physical-expr Building datafusion-physical-plan v55.0.0 (current) Built [ 38.395s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.149s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 38.619s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.150s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.669s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 79.320s] datafusion-physical-plan Building datafusion-proto v55.0.0 (current) Built [ 54.272s] (current) Parsing datafusion-proto v55.0.0 (current) Parsed [ 0.017s] (current) Building datafusion-proto v55.0.0 (baseline) Built [ 54.351s] (baseline) Parsing datafusion-proto v55.0.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-proto v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.135s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 109.940s] datafusion-proto Building datafusion-proto-models v55.0.0 (current) Built [ 25.402s] (current) Parsing datafusion-proto-models v55.0.0 (current) Parsed [ 0.129s] (current) Building datafusion-proto-models v55.0.0 (baseline) Built [ 26.018s] (baseline) Parsing datafusion-proto-models v55.0.0 (baseline) Parsed [ 0.132s] (baseline) Checking datafusion-proto-models v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.791s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field PhysicalCastNode.target_field in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1859 field PhysicalCastNode.target_field in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1859 field CastNode.target_field in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1182 field CastNode.target_field in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1182 field PhysicalTryCastNode.target_field in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1850 field PhysicalTryCastNode.target_field in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1850 field TryCastNode.target_field in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1198 field TryCastNode.target_field in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1198 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 54.868s] datafusion-proto-models Building datafusion-pruning v55.0.0 (current) Built [ 40.840s] (current) Parsing datafusion-pruning v55.0.0 (current) Parsed [ 0.012s] (current) Building datafusion-pruning v55.0.0 (baseline) Built [ 41.190s] (baseline) Parsing datafusion-pruning v55.0.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-pruning v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.079s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 83.079s] datafusion-pruning Building datafusion-sql v55.0.0 (current) Built [ 44.110s] (current) Parsing datafusion-sql v55.0.0 (current) Parsed [ 0.031s] (current) Building datafusion-sql v55.0.0 (baseline) Built [ 44.269s] (baseline) Parsing datafusion-sql v55.0.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-sql v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.259s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 90.099s] datafusion-sql Building datafusion-substrait v55.0.0 (current) Built [ 315.979s] (current) Parsing datafusion-substrait v55.0.0 (current) Parsed [ 0.018s] (current) Building datafusion-substrait v55.0.0 (baseline) Built [ 319.802s] (baseline) Parsing datafusion-substrait v55.0.0 (baseline) Parsed [ 0.017s] (baseline) Checking datafusion-substrait v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.218s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 637.962s] datafusion-substrait ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
