sunchao commented on PR #5471: URL: https://github.com/apache/datafusion-comet/pull/5471#issuecomment-5442358701
Updated in [95c744c4c](https://github.com/apache/datafusion-comet/commit/95c744c4c63af1d8a778245bd34b080d12c0904b). Addressed the coverage follow-up in 95c744c4c63a: the two structural predicates now document their relationship, and a positive dispatcher regression proves a name created only on the promoted copy reaches the original alias. The full Spark 4.1.3 JVM reactor compiled; all five selected coverage/singleton tests passed. Removing only the lift made the new regression fail. Local execution reused a previously built OSS native library; no native changes are in this follow-up. The fallback-reason provenance follow-up is tracked in https://github.com/apache/datafusion-comet/issues/5499. It covers stale-reason propagation and possible masking of the strict check while preserving legitimate literal fallback reasons. I kept the proposed DPP contamination origin explicitly unproven: Spark wraps `TrueLiteral`, and the rule ordering alone does not reproduce singleton branding. I also refreshed the stale final CI paragraph. The earlier head's reruns are green; the new commit's CI remains to be confirmed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
