sunchao commented on PR #5415: URL: https://github.com/apache/datafusion-comet/pull/5415#issuecomment-5444195862
Two source-level clarifications on [the latest analysis](https://github.com/apache/datafusion-comet/pull/5415#issuecomment-5443268056), at `c62b529a`: - The lone-`0xC3` example does not yet establish a native `false` result. [RLike](https://github.com/apache/datafusion-comet/blob/c62b529a75867ab54c3a95c456fa7e7b419b91bf/native/spark-expr/src/predicate_funcs/rlike.rs#L74) passes Arrow string values to `regex::Regex` as `&str`, not to the bytes-regex API. The [binary-to-string cast](https://github.com/apache/datafusion-comet/blob/c62b529a75867ab54c3a95c456fa7e7b419b91bf/native/spark-expr/src/conversion_funcs/cast.rs#L816) uses JVM-compatible lossy decoding. An end-to-end reproducer needs to identify how the malformed bytes reach that kernel; this is not a claim that every malformed-input path is safe. - The opt-in collation widening is real: the [literal matcher](https://github.com/apache/datafusion-comet/blob/c62b529a75867ab54c3a95c456fa7e7b419b91bf/spark/src/main/scala/org/apache/comet/serde/strings.scala#L387) accepts collated string literals, and `allowIncompatible=true` bypasses the equivalence gate. Default routing still checks both operands' collations. Moving the guard into `nativeApplicable` would tighten the explicitly incompatible opt-in policy, rather than repair default routing. These are source checks, not a rerun of the reported fuzz campaign or an executed malformed-input reproduction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
