unikdahal commented on PR #24582: URL: https://github.com/apache/datafusion/pull/24582#issuecomment-5444979183
Thanks @Jefffrey! - **Reconstructing the empty struct in `compact_view_buffers`** — good call, a zero-field struct has no child buffers to compact, so that branch now just returns the input array unchanged. - **3-row scalar in the test** — agreed, unrealistic. Reworked `test_compact_empty_struct` to wrap a single-row `StructArray` (kept a null row so null-buffer preservation is still exercised). - **CI** — the `cargo fmt` failure was unrelated formatting in the new nested test; fixed. Pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
