duongcongtoai commented on code in PR #11577:
URL: https://github.com/apache/datafusion/pull/11577#discussion_r1720902957
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2921,17 +2922,53 @@ pub enum Partitioning {
DistributeBy(Vec<Expr>),
}
+#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+pub enum ColumnUnnestType {
+ List(Vec<ColumnUnnestList>),
+ // for struct, there can only be one unnest performed on one column at a
time
+ Struct,
+ // Infer the unnest type based on column schema
+ // If column is a list column, the unnest depth will be 1
+ // This value is to support sugar syntax of old api
(unnest(columns1,columns2))
Review Comment:
tks, it is a typo
and my implementation is hard to read right now, so reviewing it can be
exausting :pray:
I'm still refactoring/simplifying to make it more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
