github-actions[bot] commented on PR #24642: URL: https://github.com/apache/datafusion/pull/24642#issuecomment-5451117209
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-common v55.0.0 (current) Built [ 35.695s] (current) Parsing datafusion-common v55.0.0 (current) Parsed [ 0.062s] (current) Building datafusion-common v55.0.0 (baseline) Built [ 35.303s] (baseline) Parsing datafusion-common v55.0.0 (baseline) Parsed [ 0.063s] (baseline) Checking datafusion-common v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.668s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron Failed in: function datafusion_common::utils::usize_from_wire, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/common/src/utils/mod.rs:1149 function datafusion_common::utils::usize_to_wire, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/common/src/utils/mod.rs:1161 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: RecordBatchMemoryCounter::count_batch_with_array_overhead, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/common/src/utils/memory.rs:203 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 73.806s] datafusion-common Building datafusion-datasource-parquet v55.0.0 (current) Built [ 50.854s] (current) Parsing datafusion-datasource-parquet v55.0.0 (current) Parsed [ 0.034s] (current) Building datafusion-datasource-parquet v55.0.0 (baseline) Built [ 51.060s] (baseline) Parsing datafusion-datasource-parquet v55.0.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion-datasource-parquet v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.149s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 103.722s] datafusion-datasource-parquet Building datafusion-proto-common v55.0.0 (current) Built [ 23.278s] (current) Parsing datafusion-proto-common v55.0.0 (current) Parsed [ 0.047s] (current) Building datafusion-proto-common v55.0.0 (baseline) Built [ 23.281s] (baseline) Parsing datafusion-proto-common v55.0.0 (baseline) Parsed [ 0.049s] (baseline) Checking datafusion-proto-common v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.109s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 49.396s] datafusion-proto-common Building datafusion-proto-models v55.0.0 (current) Built [ 26.799s] (current) Parsing datafusion-proto-models v55.0.0 (current) Parsed [ 0.128s] (current) Building datafusion-proto-models v55.0.0 (baseline) Built [ 26.481s] (baseline) Parsing datafusion-proto-models v55.0.0 (baseline) Parsed [ 0.131s] (baseline) Checking datafusion-proto-models v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.718s] 223 checks: 219 pass, 4 fail, 0 warn, 31 skip --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_missing.ron Failed in: variant PhysicalPlanType::PiecewiseMergeJoin, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1432 variant PhysicalPlanType::PiecewiseMergeJoin, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1432 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: CsvScanExecNode::terminator, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1974 CsvScanExecNode::terminator, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1974 JsonScanExecNode::newline_delimited, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:2009 JsonScanExecNode::newline_delimited, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:2009 FileScanExecConf::file_compression_type, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1928 FileScanExecConf::set_file_compression_type, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1928 FileScanExecConf::file_compression_type, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1928 FileScanExecConf::set_file_compression_type, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1928 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_proto_models::generated::datafusion::PiecewiseMergeJoinExecNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:2584 struct datafusion_proto_models::protobuf::PiecewiseMergeJoinExecNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:2584 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_missing.ron Failed in: field terminator of struct CsvScanExecNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1990 field terminator of struct CsvScanExecNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1990 field newline_delimited of struct JsonScanExecNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:2015 field newline_delimited of struct JsonScanExecNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:2015 field file_compression_type of struct FileScanExecConf, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1961 field file_compression_type of struct FileScanExecConf, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/proto-models/src/generated/prost.rs:1961 Summary semver requires new major version: 4 major and 0 minor checks failed Finished [ 56.670s] datafusion-proto-models Building datafusion-sqllogictest v55.0.0 (current) Built [ 102.984s] (current) Parsing datafusion-sqllogictest v55.0.0 (current) Parsed [ 0.021s] (current) Building datafusion-sqllogictest v55.0.0 (baseline) Built [ 105.395s] (baseline) Parsing datafusion-sqllogictest v55.0.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-sqllogictest v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.093s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 211.664s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
