goldmedal commented on code in PR #12045:
URL: https://github.com/apache/datafusion/pull/12045#discussion_r1720922312
##########
datafusion/expr/src/udwf.rs:
##########
@@ -353,6 +358,29 @@ pub trait WindowUDFImpl: Debug + Send + Sync {
fn sort_options(&self) -> Option<SortOptions> {
None
}
+
+ /// Coerce arguments of a function call to types that the function can
evaluate.
+ ///
+ /// This function is only called if [`WindowUDFImpl::signature`] returns
[`crate::TypeSignature::UserDefined`]. Most
+ /// UDAFs should return one of the other variants of `TypeSignature` which
handle common
Review Comment:
```suggestion
/// UDWFs should return one of the other variants of `TypeSignature`
which handle common
```
It looks like a typo (?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
