Xuanwo commented on code in PR #23829:
URL: https://github.com/apache/datafusion/pull/23829#discussion_r3890081241
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -4343,6 +4443,164 @@ pub struct Join {
pub null_aware: bool,
}
+/// The ordered comparison used by an [`AsOfJoin`].
+#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash)]
+pub struct AsOfMatch {
+ /// Expression evaluated against the left input.
+ pub left: Expr,
+ /// One of [`Operator::Lt`], [`Operator::LtEq`], [`Operator::Gt`], or
+ /// [`Operator::GtEq`].
+ pub op: Operator,
+ /// Expression evaluated against the right input.
+ pub right: Expr,
+}
+
+impl AsOfMatch {
+ /// Creates an ordered ASOF match condition.
+ pub fn new(left: Expr, op: Operator, right: Expr) -> Self {
+ Self { left, op, right }
+ }
+}
+
+impl Display for AsOfMatch {
+ fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+ write!(f, "{} {} {}", self.left, self.op, self.right)
+ }
+}
+
+/// Match each left row with at most one ordered row from the right input.
+#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+pub struct AsOfJoin {
+ /// Left input. Every left row is preserved exactly once.
+ pub left: Arc<LogicalPlan>,
+ /// Right input.
+ pub right: Arc<LogicalPlan>,
+ /// Equality clauses expressed as pairs of left and right expressions.
+ pub on: Vec<(Expr, Expr)>,
+ /// Ordered match condition.
+ pub match_condition: Box<AsOfMatch>,
+ /// Whether equality keys came from `ON` or `USING`.
+ pub join_constraint: JoinConstraint,
+ /// Output schema.
+ pub schema: DFSchemaRef,
+}
+
+impl AsOfJoin {
+ /// Creates an ASOF join and validates its logical contract.
+ pub fn try_new(
+ left: Arc<LogicalPlan>,
+ right: Arc<LogicalPlan>,
+ on: Vec<(Expr, Expr)>,
+ match_condition: AsOfMatch,
+ join_constraint: JoinConstraint,
+ ) -> Result<Self> {
Review Comment:
A shared helper would be awkward because the logical layer validates the
pre-coercion contract, while the physical layer adds exact-type and
bounded-input requirements. I added comments at both public entry points to
keep the shared checks aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
