alamb commented on PR #15591: URL: https://github.com/apache/datafusion/pull/15591#issuecomment-5477734136
Makes sense > According to the analysis of the coding agent, Emit::Last can be easily implemented for most GroupValues and GroupsAccumulator (compare with the totally blocked approach like this pr) That might also show us a way towards incremental / blocked management -- we could implement `EmitTo::Last` for all accumulators, and then potentially optimize the implementations one by one to use blocked allocations internally The trick would be to make sure `EmitTo::Last` lines up with however the internal blocks are laid out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
