hhhizzz commented on PR #23182: URL: https://github.com/apache/datafusion/pull/23182#issuecomment-5480565323
> I see that the test added here does not reproduce the actual bug, it just test internal implementation of `MaterializedAggregateOutput` which is a problem as I'm refactoring the code as part of Blocked implementation and I worry I might break this hack You're right. This was essentially a workaround until blocked/chunked state management is available. The proper solution is to store aggregate state in blocks and emit those blocks directly, so this helper and its implementation-specific test do not need to be preserved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
