hhhizzz commented on PR #23182: URL: https://github.com/apache/datafusion/pull/23182#issuecomment-5494417088
Ah, I see what you mean. This was a performance/complexity regression rather than a correctness issue, so a normal integration test that only checks the output would still pass. But we can add an end-to-end test that guards against the problematic path: run the Single/Final aggregate with more groups than `batch_size`, and fail if unordered terminal output falls back to destructive `EmitTo::First`, similar to the partial-path test in #23250. I will follow up and add that test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
