adibmbrk opened a new pull request, #5607: URL: https://github.com/apache/datafusion-comet/pull/5607
## Which issue does this PR close? Closes #5584. ## Rationale for this change `length`, `bit_length`, and `octet_length` rejected `BinaryType` input and fell the entire projection back to Spark, even though the operation is trivial (`numBytes()`) and `BinaryType` is already supported by the codegen dispatcher. ## What changes are included in this PR? - Mix `CodegenDispatchFallback` into `CometLength`, `CometBitLength`, and `CometOctetLength` so binary input routes through the JVM codegen dispatcher (Spark's own `doGenCode`, run inside the Comet pipeline) instead of falling back to Spark. - Regenerate the affected docs rows (`length`, `len`, `char_length`, `character_length`, `bit_length`, `octet_length`) from Native to Hybrid. ## How are these changes tested? Updated the `length.sql`, `bit_length.sql`, and `octet_length.sql` fixtures: the binary cases now assert native-vs-Spark parity (`checkSparkAnswerAndOperator`) instead of `expect_fallback`. Added binary coverage to `length.sql`. Ran against Spark 4.1: - `CometStringExpressionSuite` — 33 succeeded, 0 failed. - `CometSqlFileTestSuite` — 467 succeeded, 0 failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
