paleolimbot commented on PR #23169: URL: https://github.com/apache/datafusion/pull/23169#issuecomment-5496358637
> I would like to bring up a question that is probably better asked now, as frustrating as it may be, than after merging: are these really the semantics we want? I think the semantics in this PR are a standalone improvement over the current situation, which is not consistent between trycast and cast / prevents using DataFusion's SQL parser to do casts into extension types. > I don't think we should be viewing this as the minimal back port required. Back ports are to fix bugs introduced in that release or recent releases. I've always considered this (the target field of a cast / try cast is not reflected in its `return_field()`) a bug. Technically it was a bug that was introduced before the correct behaviour was ever released, it just seems that nobody noticed or cared until now. As always, happy to update this PR if there's a reasonable chance it will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
