cestercian opened a new pull request, #5619: URL: https://github.com/apache/datafusion-comet/pull/5619
## Which issue does this PR close? Closes #5611. ## Rationale for this change `lower_enabled.sql` and `upper_enabled.sql` were meant to cover the native case-conversion path, but they set the no-op config `spark.comet.expression.Lower/Upper.allowIncompatible`. The native path is gated by `spark.comet.caseConversion.enabled`, so these fixtures currently exercise the same codegen dispatcher path as plain `lower.sql` / `upper.sql`. ## What changes are included in this PR? - Point both `_enabled` fixtures at `spark.comet.caseConversion.enabled=true` - Update header comments to describe the native path (ASCII inputs unchanged) - Do **not** add `expect_native(...)` yet — that depends on open #5610 ## Are these changes tested? Yes. After `make core` (Spark 4.1): ``` ./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite lower_enabled" -Dtest=none ./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite upper_enabled" -Dtest=none ``` Both passed (1 test each, 0 failures). ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
