cdelmonte-zg commented on code in PR #24750:
URL: https://github.com/apache/datafusion/pull/24750#discussion_r3912250064
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -732,6 +732,7 @@ impl CSEController for ExprCSEController<'_> {
| Expr::Wildcard { .. }
| Expr::Lambda(_)
| Expr::LambdaVariable(_)
+ | Expr::WindowFunction(..)
Review Comment:
Thank you, happy that it works!
I followed your suggestion, but the SQL planner deduplicates identical
window expressions before they reach CSE, so the SQLLogicTest could not
reproduce the bug.
I added an execution-level regression test, tho. Is that okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
