alamb opened a new pull request, #2483: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2483
## Which issue does this PR close? N/A — dependency maintenance. ## Rationale for this change `syn` 3.0 was released in July 2026 (currently at 3.0.4); `sqlparser_derive` was pinned to `2.0`. Updating keeps us on the maintained major version and avoids downstream builds pulling in duplicate `syn` majors. `syn` 3.0's MSRV (Rust 1.71) is the same as the `syn` 2.0.117+ releases we already resolve to, so there is no MSRV impact. ## What changes are included in this PR? - Bump `syn` from `2.0` to `3.0` in `derive/Cargo.toml` - Adapt to the one breaking change that affects us: `syn::Receiver` no longer has a `reference` field — the reference-ness of a method receiver now lives in a `kind: ReceiverKind` enum. The `&self`-detection in `is_bool_method` (`derive/src/dialect.rs`) now matches on `ReceiverKind::Reference(_, _, None)` (a `&self` receiver with no `mut`), which is equivalent to the old `r.reference.is_some() && r.mutability.is_none()` check. ## Is this a breaking API change? **No — `syn` does not appear in the public API.** `sqlparser_derive` is a proc-macro crate (`proc-macro = true`), so its entire public API is the three exported macros (`Visit`, `VisitMut`, `derive_dialect`), which only take and return `proc_macro::TokenStream`; proc-macro crates cannot export types, so `syn` types cannot leak into the API. The main `sqlparser` crate does not reference `syn` at all. The upgrade is purely an internal implementation change, so a minor version bump of `sqlparser_derive` is sufficient when releasing. ## Are these changes tested? `cargo test --all-features` passes (22/22 suites, 0 failures), which includes the `sqlparser_derive_dialect` test and the visitor tests that exercise the derive macros end to end. ## Are there any user-facing changes? No user-facing API changes. Downstream crates that enable the `visitor` or `derive-dialect` features will build `syn` 3.0 instead of 2.0 once a new `sqlparser_derive` is published. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
