andygrove commented on PR #23880:
URL: https://github.com/apache/datafusion/pull/23880#issuecomment-5529229269
@comphead all seven of these went in as f622ed1c0, which landed the day
after your review — my "take another look" ping didn't say what had changed, so
here is the mapping:
**`quote.slt`** — new `# LargeUtf8 and Utf8View inputs` and `# Multi-row
batches, so the output builder is reused across rows` sections:
- `LargeUtf8`: `quote(arrow_cast('it''s', 'LargeUtf8'))` and the
empty-string variant, so `quote_array::<i64>` and the `LargeUtf8` arm of
`return_type` are both reached.
- `Utf8View`: `quote(arrow_cast('it''s', 'Utf8View'))` plus a batch that
deliberately mixes values inlined in the views (<= 12 bytes) with one held in a
data buffer, since `total_bytes_len()` counts those two differently.
- `SELECT quote(NULL)` and `SELECT quote('')` are now present, covering
`quote_impl`'s `append_null()` branch and the empty-run fallback.
- Cross-row builder reuse: `SELECT quote(c) FROM VALUES ('a'), ('it''s'),
(NULL), (''), ('x''''y')`, with `LargeUtf8` and `Utf8View` batch variants
alongside.
**`soundex.slt`**:
- `LargeUtf8` and `Utf8View` cases now exercise `soundex_array::<i64>` and
`soundex_view`.
- Non-ASCII alphabetic first characters: `Ñoño` and `Éclair`. Worth noting
the `from_utf8_unchecked` you were guarding against is gone — f622ed1c0 dropped
the `unsafe` block entirely, so there is no longer a SAFETY invariant to
protect if the first-char test broadens.
- Multi-row batch over `VALUES`, in both `Utf8` and `Utf8View`.
Sliced and empty arrays can't be built through sqllogictest, so those stayed
as Rust unit tests: `soundex_sliced_array`, `soundex_empty_array`, and on the
quote side `quote_sliced_array`, `quote_sliced_view_array`, `quote_empty_array`.
Also addressed @Jefffrey's note above — the offsets `match` is now a plain
`unwrap` with the non-empty guarantee recorded in a comment.
Just merged latest `main` in. Ready for another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
