sunchao commented on code in PR #5700:
URL: https://github.com/apache/datafusion-comet/pull/5700#discussion_r3938614934
##########
native/spark-expr/benches/common/mod.rs:
##########
@@ -21,17 +21,21 @@
#![allow(dead_code)]
use arrow::array::{
- builder::StringBuilder, ArrayRef, Float64Array, Int64Array, RecordBatch,
StringArray,
- TimestampMicrosecondArray,
+ builder::{BooleanBuilder, ListBuilder, StringBuilder},
+ ArrayRef, Float64Array, Int64Array, ListArray, RecordBatch,
Review Comment:
### Correctness
[P2] Restore the existing array-type imports
Could you retain `StringArray` and `TimestampMicrosecondArray` in this
import list? The unchanged `string_array` and `timestamp_micros_array` helpers
still reference them at lines 76 and 97. Rust type-checks those helpers even
when a particular benchmark does not call them, so this breaks both the seven
new targets and existing users of `common/mod.rs`. The benchmark-check and Rust
CI jobs on merge `013199ba` both fail with E0425 for these exact types.
Restoring the two imports makes the shared helpers resolvable again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
