sunchao commented on code in PR #5700:
URL: https://github.com/apache/datafusion-comet/pull/5700#discussion_r3942401778
##########
native/spark-expr/benches/common/mod.rs:
##########
@@ -20,18 +20,19 @@
//! auto-discovery, which only looks at `benches/*.rs`, does not treat it as a
bench target.
#![allow(dead_code)]
-use arrow::array::{
- builder::StringBuilder, ArrayRef, Float64Array, Int64Array, RecordBatch,
StringArray,
- TimestampMicrosecondArray,
+use arrow::array::{builder::{BooleanBuilder, ListBuilder, StringBuilder},
ArrayRef, Float64Array, Int64Array, ListArray, RecordBatch, StringArray,
TimestampMicrosecondArray};
Review Comment:
### Correctness
[P2] Format the restored import block to unblock validation
Could you apply the existing Rust formatter to this import block while
retaining both restored names? The missing-import failure is fixed, but this
replacement line makes Linux lint, macOS lint and benchmark validation fail
their formatting checks. The benchmark job then skips Clippy and benchmark
compilation. All three jobs checked out merge ebb2626b with this exact
shared-module blob, and a local read-only rustfmt check using the head
configuration produces the same multiline-import diff. This needs to pass
before those validation stages can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
