ShayanGho commented on code in PR #24943: URL: https://github.com/apache/datafusion/pull/24943#discussion_r3938249173
########## datafusion/sqllogictest/test_files/spark/math/factorial.slt: ########## @@ -62,5 +62,35 @@ NULL NULL NULL -query error Error during planning: Failed to coerce arguments to satisfy a call to 'factorial' function -SELECT factorial(5::BIGINT); +# Spark declares factorial(INT) with ImplicitCastInputTypes, so every integer width is +# accepted; an untyped literal (Int64 in DataFusion) must work too. Values from Spark 4.2.0. Review Comment: Removed the UInt64 case and updated the query signature and expected output. The remaining cases use types available in Spark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
