comphead commented on code in PR #24943: URL: https://github.com/apache/datafusion/pull/24943#discussion_r3941602184
########## datafusion/sqllogictest/test_files/spark/math/factorial.slt: ########## @@ -62,5 +62,21 @@ NULL NULL NULL -query error Error during planning: Failed to coerce arguments to satisfy a call to 'factorial' function -SELECT factorial(5::BIGINT); +# Signed integer inputs and NULL; expected results verified with Spark 4.2.0. Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
