goutamadwant commented on code in PR #24836:
URL: https://github.com/apache/datafusion/pull/24836#discussion_r3941711706
##########
datafusion/pruning/benches/string_in_list_pruning.rs:
##########
@@ -101,20 +105,20 @@ struct IntervalStatistics {
}
impl IntervalStatistics {
- fn new(domain_size: usize) -> Self {
- let min =
StringViewArray::from_iter_values((0..CONTAINERS).map(|index| {
+ fn new(domain_size: usize, container_count: usize) -> Self {
Review Comment:
@kumarUjjawal thanks for checking! pushed a fix to address this. each
hit/miss interval pair is now mapped to an evenly spaced position across the
full domain, including both endpoints, and the distribution repeats only when
the pair count exceeds the domain size. For the 1,024-value domain, 16 and 256
containers therefore sample 8 and 128 evenly distributed positions
respectively, while 4,096 containers cover all 1,024 positions twice.
resolved the conflicts too. Let me know if you have any other comments.
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
