wirybeaver opened a new pull request, #5728: URL: https://github.com/apache/datafusion-comet/pull/5728
## Which issue does this PR close? Part of #4632. ## Rationale for this change Native Lance reads need an optional contrib boundary that does not add Lance dependencies or runtime behavior to default Comet builds. This separates the build and planner wiring from the later native reader implementation, following the existing Delta build-gate pattern. ## What changes are included in this PR? - Adds an optional `comet-contrib-lance` crate and `contrib-lance` Cargo feature. - Adds the typed Lance scan payload and a feature-gated native planner dispatch. - Adds an inert Lance planner entry point that returns `NotImplemented`, allowing Spark fallback until the real reader lands. - Does not depend on the Lance Rust crate and does not change default Comet runtime behavior. The native Lance reader prototype in #4633 will be rebased on top of this PR. ## How are these changes tested? - `cargo check -p datafusion-comet --locked` - `cargo check -p datafusion-comet --features contrib-lance --locked` - `cargo check -p datafusion-comet --no-default-features --locked` - `cargo check -p datafusion-comet --no-default-features --features contrib-lance --locked` - `cargo clippy -p datafusion-comet --no-default-features --features contrib-lance --locked -- -D warnings` - `cargo fmt --all -- --check` - `git diff --check` No runtime test is added because this PR deliberately introduces no executable Lance read path; the feature-gated planner returns `NotImplemented`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
