Xuanwo opened a new pull request, #24965:
URL: https://github.com/apache/datafusion/pull/24965

   ## Which issue does this PR close?
   
   - Part of #318.
   - Umbrella PR: #23738.
   - Follow-up to #23830.
   
   ## Rationale for this change
   
   Regular and ASOF join unparsing separately handled projected inputs, nested 
right joins, and output projection reconstruction. Keeping those branches 
separate makes fixes easy to apply to one join kind but miss the other.
   
   GitHub shows the cumulative stack because fork branches cannot be selected 
as upstream PR bases. The isolated diff is:
   
https://github.com/Xuanwo/datafusion/compare/xuanwo/asof-sql...xuanwo/asof-unparser-refactor
   
   ## What changes are included in this PR?
   
   - Route regular and ASOF join inputs through one private preparation path.
   - Keep left-side join chaining, right-side nesting, and ASOF derived-input 
boundaries explicit through `JoinInputMode`.
   - Preserve existing SQL output and projection behavior.
   
   ## Are these changes tested?
   
   Yes:
   
   - `cargo fmt --all`
   - `cargo clippy --all-targets --all-features -- -D warnings`
   - `cargo test -p datafusion-sql --test sql_integration`
   - Extended workspace tests from the contributor guide
   
   ## Are there any user-facing changes?
   
   No. This is a behavior-preserving unparser refactor.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to