osipovartem opened a new issue, #24974:
URL: https://github.com/apache/datafusion/issues/24974
### Describe the bug
On current `main`, the required full lint command fails in
`datafusion-sqllogictest` when the `postgres` feature is enabled:
```text
error: this argument is passed by value, but not consumed in the function
body
--> datafusion/sqllogictest/src/engines/conversion.rs:99:37
|
99 | pub(crate) fn decimal_to_str(value: BigDecimal) -> String {
| ^^^^^^^^^^
= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
```
### To Reproduce
```bash
cargo clippy --all-targets --all-features -- -D warnings
```
### Expected behavior
The required workspace lint command succeeds. `decimal_to_str` only reads
the `BigDecimal`, so it can accept a reference without changing output.
### Additional context
Observed on commit `722cbf2e7` with the repository-pinned Rust 1.97
toolchain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
