rich7420 opened a new pull request, #5745: URL: https://github.com/apache/datafusion-comet/pull/5745
## Which issue does this PR close? Part of #5569 (Variant shredding suites). ## Rationale for this change The Spark 4.1.3 patch still excludes both Variant shredding suites for #2209, which was fixed by #4084. Restore their coverage while keeping a focused exclusion for #5741. ## What changes are included in this PR? Remove `IgnoreCometSuite` from `VariantShreddingSuite` and `ParquetVariantShreddingSuite`. Tag only `variant logical type annotation - ignore variant annotation` with `IgnoreComet`, linked to #5741. This restores 14 tests with Comet enabled and preserves all 15 with Comet disabled. Regenerated `dev/diffs/4.1.3.diff` from Spark v4.1.3 sources. Regeneration also refreshes the existing pom.xml result hash without changing its patch content. ## How are these changes tested? [Spark 4.1.3 / JDK 17 fork CI](https://github.com/rich7420/datafusion-comet/actions/runs/34039714157) passed, including all seven Spark SQL test groups. The restored suites ran 14 tests successfully, with only the #5741 case ignored. The Hive job was rerun after a runner shutdown. The regenerated patch applies cleanly to Spark v4.1.3, and the modified Spark sources pass `git diff --check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
