2010YOUY01 commented on code in PR #24996:
URL: https://github.com/apache/datafusion/pull/24996#discussion_r3946166555
##########
datafusion/physical-plan/src/aggregates/ordered_partial_stream.rs:
##########
@@ -116,6 +116,7 @@ pub(crate) struct OrderedPartialAggregateStream {
reservation: MemoryReservation,
baseline_metrics: BaselineMetrics,
reduction_factor: metrics::RatioMetrics,
+ early_emit_count: metrics::Count,
Review Comment:
In `OrderedPartialAggregateStream`, intermediate states are doing early emit
for a different reason, I think reusing the same metric name can cause
confusion, and it also seems less useful. Overall I recommend to remove it here.
##########
datafusion/physical-plan/src/aggregates/grouped_hash_stream.rs:
##########
@@ -385,6 +385,9 @@ pub(crate) struct GroupedHashAggregateStream {
/// Reduction factor metric, calculated as `output_rows/input_rows` (only
for partial aggregation)
reduction_factor: Option<metrics::RatioMetrics>,
+
+ /// Number of times accumulated states were emitted due to memory pressure.
+ early_emit_count: Option<metrics::Count>,
Review Comment:
Let's revert the changes in this file. It's deprecated now, and will no
longer get maintained
https://github.com/apache/datafusion/pull/24961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
