kosiew commented on code in PR #24811:
URL: https://github.com/apache/datafusion/pull/24811#discussion_r3947477240
##########
datafusion/common/src/config.rs:
##########
@@ -1116,6 +1116,7 @@ config_namespace! {
/// DataFusion will not enforce batch size in joins. Enforcing batch
size
/// in joins can reduce memory usage when joining large
/// tables with a highly-selective join filter, but is also slightly
slower.
+ /// Note: this option currently only applies to the symmetric hash
join.
Review Comment:
There is also
```
/// Enables or disables the enforcement of batch size in joins
pub fn with_enforce_batch_size_in_joins(
```
in
`datafusion/execution/src/config.rs`
Could we add the same note here that this option currently only applies to
the symmetric hash join? That would keep the public `SessionConfig`
builder/getter rustdocs consistent with the config reference, so Rust API users
see the correct scope directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
