lyne7-sc commented on code in PR #24817: URL: https://github.com/apache/datafusion/pull/24817#discussion_r3951056280
########## datafusion/sqllogictest/test_files/push_down_filter_regression.slt: ########## @@ -415,15 +413,15 @@ CREATE EXTERNAL TABLE agg_dyn_mixed (a INT, b INT, c INT) STORED AS PARQUET LOCATION 'test_files/scratch/push_down_filter_regression/agg_dyn_mixed/'; -# -> DynamicFilter [ a < 1 OR a > 8 OR b > 12 ] (MIN(c+1) dropped as unsupported) +# No dynamic filter because not every aggregate has a safe predicate. query TT EXPLAIN ANALYZE SELECT MIN(a), MAX(a), MAX(b), MIN(c + 1) FROM agg_dyn_mixed; Review Comment: Good point. I've added a result check and adjusted the test data so the old implementation produces the wrong result. The test passes with the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
