lyne7-sc commented on code in PR #24817:
URL: https://github.com/apache/datafusion/pull/24817#discussion_r3951059354
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -778,10 +779,10 @@ struct AggrDynFilter {
/// The current bounds for the dynamic filter, updates during the
execution to
/// tighten the bound for more effective pruning.
///
- /// Each vector element is for the accumulators that support dynamic
filter.
- /// e.g. This `AggregateExec` has accumulator:
- /// min(a), avg(a), max(b)
- /// And this field stores [PerAccumulatorDynFilter(min(a)),
PerAccumulatorDynFilter(min(b))]
+ /// Each vector element corresponds to one aggregate expression. Dynamic
filtering
+ /// is enabled only when every aggregate expression is supported, so this
vector
+ /// contains an entry for every accumulator. For example, `min(a), max(b)`
produces
+ /// entries for `min(a)` and `max(b)`.
supported_accumulators_info: Vec<PerAccumulatorDynFilter>,
Review Comment:
Yes, that makes sense to me. renamed to `accumulator_dyn_filter_info`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
