kosiew commented on code in PR #24869: URL: https://github.com/apache/datafusion/pull/24869#discussion_r3951213318
########## datafusion/sqllogictest/test_files/aggregate_filter_selection.slt: ########## @@ -44,9 +44,81 @@ ORDER BY g; 3 NULL 4 2 +# Each aggregate must compact group indices using its own FILTER. Cover both +# primitive and boolean group accumulators, including groups rejected by both. +query IIB Review Comment: Could we add a SQL-level test where the `FILTER` predicate contains NULL values, ideally with a fallible aggregate argument? The helper unit test covers NULLs in the bitmap, but the new `true_count` -> `filter_record_batch` path is not covered end to end. I think a test here would be useful to verify that NULL is treated as not selected and that the compacted group IDs stay aligned with the aggregate arguments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
