lyne7-sc commented on code in PR #24869: URL: https://github.com/apache/datafusion/pull/24869#discussion_r3958913465
########## datafusion/sqllogictest/test_files/aggregate_filter_selection.slt: ########## @@ -44,9 +44,81 @@ ORDER BY g; 3 NULL 4 2 +# Each aggregate must compact group indices using its own FILTER. Cover both +# primitive and boolean group accumulators, including groups rejected by both. +query IIB Review Comment: Thanks for the suggestion! I've added an SLT covering NULL filter predicates with a fallible aggregate argument and interleaved groups to verify that compacted group IDs stay aligned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
